]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
Race for l2pop when ports go up/down on same host
authorVivekanandan Narasimhan <vivekanandan.narasimhan@hp.com>
Tue, 23 Sep 2014 09:25:16 +0000 (02:25 -0700)
committerIhar Hrachyshka <ihrachys@redhat.com>
Fri, 17 Oct 2014 08:40:04 +0000 (08:40 +0000)
commit4a84be59db123df8618e5c0d0614c8a927e68196
tree568e403def3385c2b354274fefaa3deaeff7893f
parent0d0c376d09d85a0eabeb8c9258349d1e63a5cdf0
Race for l2pop when ports go up/down on same host

With l2pop enabled, race exists in delete_port_postcommit
when both create/update_port and delete_port deal with
different ports on the same host, where such ports are
either the first (or) last on same network for that host.
This race happens outside the DB locking zones in
the respective methods of ML2 plugin.

To fix this, we have moved determination of
fdb_entries back to delete_port_postcommit and removed
delete_port_precommit altogether from l2pop mechanism
driver.  In order to accomodate dvr interfaces, we
are storing and re-using the mechanism-driver context
which hold dvr-port-binding information while
invoking delete_port_postcommit.  We loop through
dvr interface bindings invoking delete_port_postcommit
similar to delete_port_precommit.

Closes-Bug: #1372438
Change-Id: If0502f57382441fdb4510c81a89794f57a38e696
(cherry picked from commit 3cd2163d5105faad389bee5175ef446f0bb90289)
neutron/plugins/ml2/drivers/l2pop/mech_driver.py
neutron/plugins/ml2/plugin.py
neutron/tests/unit/ml2/drivers/test_l2population.py