]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commit
Dell Storage Center: Add retries to API calls
authorSean McGinnis <sean_mcginnis@dell.com>
Thu, 12 Feb 2015 20:52:56 +0000 (14:52 -0600)
committerSean McGinnis <sean_mcginnis@dell.com>
Tue, 17 Feb 2015 14:14:56 +0000 (08:14 -0600)
commit49dd3785229200d649d1291e556ae30566763bce
treec9f23f13fe322208f16cbcf6bd0b524be9d69323
parentd4e75340ecd1b8a070b764626667ae47d561e26d
Dell Storage Center: Add retries to API calls

In heavily loaded networks we have seen some cases
of temporary ConnectionErrors when making REST API
calls. There are usually successful calls just prior
and immediately after these failures, so it appears
to be a transient condition.

This patch utilizes the recently merged retry decorator
to add some retry handling to the REST API calls when
this condition is encountered.

With a test script looping through repeatedly running
CI against this first patch I was able to validate
that it addresses the issue. Out of 20 runs, a full
2/3 of the tests passed showing that the retry was
used. These test runs would have failed without the
retry.

The output from these test runs can be viewed here:

http://oslogs.compellent.com/?C=N;O=D

Pertinent results are dell-sc-iscsi-1554792015-12*

Once merged we should be able to enable full third
party CI testing with some expectation of reliable
results.

Closes-Bug: 1422742
Change-Id: I1279a7696068aee534498bb18f4f6b4fbb7a33d5
cinder/volume/drivers/dell/dell_storagecenter_api.py