]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
Use assertIn and assertNotIn
authorCedric Brandily <zzelle@gmail.com>
Sun, 4 Oct 2015 18:48:44 +0000 (20:48 +0200)
committerCedric Brandily <zzelle@gmail.com>
Mon, 5 Oct 2015 18:47:18 +0000 (20:47 +0200)
commit49746ca4749c45d2772289061f161145eb5ad2b8
tree73927eb734087492c15098a61dca92ce42cad46d
parent3552393eb0137b16fe86b1dbdf7137758c93b795
Use assertIn and assertNotIn

Neutron tests should use:

  self.assertIn(value, list)
  self.assertNotIn(value, list)

instead of:

  self.assertTrue(value in list)
  self.assertFalse(value in list)

because assertIn and assertNotIn raise more meaningful errors:

  self.assertIn(3, [1, 2]
  >>> MismatchError: 3 not in [1, 2]

  self.assertTrue(3 in [1, 2])
  >>> AssertionError: False is not true

Closes-Bug: #1218713

Change-Id: Ic8492a88935bf005feb9dae726a4bee604a8bd09
doc/source/devref/effective_neutron.rst
neutron/tests/api/test_ports.py
neutron/tests/unit/agent/l3/test_item_allocator.py
neutron/tests/unit/agent/l3/test_router_processing_queue.py
neutron/tests/unit/db/test_db_base_plugin_v2.py
neutron/tests/unit/plugins/ml2/drivers/l2pop/test_mech_driver.py
neutron/tests/unit/plugins/ml2/test_rpc.py