]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
Check if interface exists in bridge prior to adding.
authorGary Kotton <gkotton@redhat.com>
Sun, 1 Jul 2012 07:06:07 +0000 (03:06 -0400)
committerGary Kotton <gkotton@redhat.com>
Mon, 2 Jul 2012 15:27:47 +0000 (11:27 -0400)
commit4742e34a8979d4a9ddb8ea58c0f2c5448723a6fb
tree10683b502e6693d0b40ed08fefbe5047b433c161
parent6d9ddf1c3737762fa12ce3b910075ed05da48cd9
Check if interface exists in bridge prior to adding.

This fixes bug 1019730. The fix for bug 1000406 ensures that return
values of shell commands are checked. The command
    utils.execute(['brctl', 'addif', bridge_name, interface],
                   root_helper=self.root_helper)
would cause an exception if there was more than one attachment
on the network. The reason for this was the interface already existed
on the bridge.

Change-Id: I8a1f6cc7be930c04ce302d7f87814b9bd5bed129
quantum/plugins/linuxbridge/agent/linuxbridge_quantum_agent.py