]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commit
Remove useless logging from unit tests
authorSean McGinnis <sean_mcginnis@dell.com>
Wed, 1 Jul 2015 20:14:57 +0000 (15:14 -0500)
committerWalter A. Boring IV (hemna) <walter.boring@hp.com>
Mon, 13 Jul 2015 17:39:44 +0000 (17:39 +0000)
commit46e1f1741d85c946f012d1c1da0189dec85d1f08
tree9325d08f457ff2c08af1b011c8a3904c055371c4
parent409bc281838a1c1399940a92a72d1192c6cd480d
Remove useless logging from unit tests

It has been discussed that there really isn't much point in having
unit tests making any kind of logger calls. Some usage has already
been cleaned up. This patch removes the remaining instances of log
calls under the cinder/tests directory.

Also cleaned up a lot of cases where the source files would import
oslo_logging and declare a LOG variable which was never actually
used.

Leaving logging in the cinder/tests/unit/integrated tree for now
until a plan is decided as to what to do with all of these type of
tests.

Added hacking check to prevent new instances from slipping by code
reviews.

Change-Id: If177394486d5c92fa5466cd3825b15d30cf5fb18
57 files changed:
HACKING.rst
cinder/hacking/checks.py
cinder/tests/unit/api/contrib/test_cgsnapshots.py
cinder/tests/unit/api/contrib/test_hosts.py
cinder/tests/unit/api/contrib/test_volume_transfer.py
cinder/tests/unit/api/test_router.py
cinder/tests/unit/api/v1/test_snapshots.py
cinder/tests/unit/api/v2/test_snapshots.py
cinder/tests/unit/brick/fake_lvm.py
cinder/tests/unit/brick/test_brick_lvm.py
cinder/tests/unit/db/test_purge.py
cinder/tests/unit/db/test_qos_specs.py
cinder/tests/unit/db/test_transfers.py
cinder/tests/unit/fake_driver.py
cinder/tests/unit/fake_utils.py
cinder/tests/unit/image/fake.py
cinder/tests/unit/scheduler/test_scheduler.py
cinder/tests/unit/test_blockbridge.py
cinder/tests/unit/test_dellfc.py
cinder/tests/unit/test_dellsc.py
cinder/tests/unit/test_dellscapi.py
cinder/tests/unit/test_drbdmanagedrv.py
cinder/tests/unit/test_emc_vmax.py
cinder/tests/unit/test_emc_xtremio.py
cinder/tests/unit/test_eqlx.py
cinder/tests/unit/test_gpfs.py
cinder/tests/unit/test_hacking.py
cinder/tests/unit/test_hitachi_hnas_backend.py
cinder/tests/unit/test_hitachi_hnas_iscsi.py
cinder/tests/unit/test_hitachi_hnas_nfs.py
cinder/tests/unit/test_hp3par.py
cinder/tests/unit/test_hplefthand.py
cinder/tests/unit/test_huawei_18000.py
cinder/tests/unit/test_ibm_flashsystem.py
cinder/tests/unit/test_ibm_flashsystem_iscsi.py
cinder/tests/unit/test_ibmnas.py
cinder/tests/unit/test_netapp.py
cinder/tests/unit/test_netapp_eseries_iscsi.py
cinder/tests/unit/test_netapp_nfs.py
cinder/tests/unit/test_nimble.py
cinder/tests/unit/test_qos_specs.py
cinder/tests/unit/test_rbd.py
cinder/tests/unit/test_srb.py
cinder/tests/unit/test_storwize_svc.py
cinder/tests/unit/test_tintri.py
cinder/tests/unit/test_volume_configuration.py
cinder/tests/unit/test_volume_transfer.py
cinder/tests/unit/test_volume_types.py
cinder/tests/unit/test_volume_utils.py
cinder/tests/unit/test_zfssa.py
cinder/tests/unit/volume/drivers/netapp/dataontap/test_nfs_cmode.py
cinder/tests/unit/volume/drivers/test_datera.py
cinder/tests/unit/volume/drivers/test_hgst.py
cinder/tests/unit/zonemanager/test_brcd_fc_san_lookup_service.py
cinder/tests/unit/zonemanager/test_brcd_fc_zone_client_cli.py
cinder/tests/unit/zonemanager/test_brcd_fc_zone_driver.py
cinder/tests/unit/zonemanager/test_brcd_lookup_service.py