]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
L3 RPC loop could delete a router on concurrent update
authorAttila Fazekas <afazekas@redhat.com>
Sun, 4 May 2014 17:54:37 +0000 (19:54 +0200)
committerAttila Fazekas <afazekas@redhat.com>
Mon, 5 May 2014 15:54:30 +0000 (17:54 +0200)
commit45381fe1c742c75773d97f1c0bd1f3cb1e7a6468
treeacc873f8b6a1ed551afee3489913e333b0911bb7
parente3d0c2b811b3b401bd82d30395d78c912e4a55b8
L3 RPC loop could delete a router on concurrent update

routers_updated does not acquire any lock just updates
a set for future rpc loop processing.

The self.updated_routers can be changed by concurrent update
notification. If this change happens at the time around the
self.plugin_rpc.get_routers call, the additional routers
- by mistake - is considered as admin_state_up=false routers, which
 are safe to delete.

Creating a local copy of the updated_routers and preserve
the fresh updated_routers entries for the next _rpc_loop
operations.

Change-Id: Icc7377f9c29e248c3b34562465e859b15ecc2ec3
Closes-Bug: #1315467
Partial-Bug: #1253896
neutron/agent/l3_agent.py