]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
Move ARP responder test to sanity command
authorAssaf Muller <amuller@redhat.com>
Thu, 22 May 2014 11:38:30 +0000 (14:38 +0300)
committerAssaf Muller <amuller@redhat.com>
Tue, 29 Jul 2014 15:44:07 +0000 (18:44 +0300)
commit43c1f98f074549611db90b6c333d2c54d7e4d4b3
treec007a11285471b1042b168aff21969617a73383e
parent8820fefeb36daba63dd49d822ca87e2ed54ed5f7
Move ARP responder test to sanity command

Additionally, the patch improves the check itself:
To check if the currently installed OVS supports the ARP responder
feature, we try to add a flow that references an OpenFlow ARP
extension via ofctl. The test may fail due to an (expected)
Runtime error, or due to some other unexpected error.
In such a case the error was previously masked and tossed away.

* Clean up ARP responder unit test
* Extract ARP responder flow actions to be used by the unit
  tests, functional test as well as the ARP responder code itself

After this patch, if the sanity check returned False but the
user never ran it or ignored its results, the OVS agent will
output errors to the log every time an ARP entry is (attempted)
to be added or removed from the flow table.

Closes-Bug: #1323718
Change-Id: I428c954d6561cd398a1e580804a9482969a154af
neutron/agent/linux/ovs_lib.py
neutron/cmd/sanity/checks.py
neutron/cmd/sanity_check.py
neutron/plugins/openvswitch/agent/ovs_neutron_agent.py
neutron/plugins/openvswitch/common/constants.py
neutron/tests/functional/sanity/test_sanity.py
neutron/tests/unit/agent/linux/test_ovs_lib.py
neutron/tests/unit/openvswitch/test_ovs_neutron_agent.py
neutron/tests/unit/openvswitch/test_ovs_tunnel.py