]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
Don't snat traffic between fixed IPs behind same router
authorJenkins <jenkins@review.openstack.org>
Fri, 16 Oct 2015 02:26:57 +0000 (02:26 +0000)
committerHong Hui Xiao <xiaohhui@cn.ibm.com>
Tue, 10 Nov 2015 11:24:37 +0000 (06:24 -0500)
commit4341a4faeed937d014e95a94b77844d5a835acbe
treef3f109d549ef6405b8dac1e6d4492a64cceedd04
parent2945ddf8079e0a63679a61cad606e6c633a2e293
Don't snat traffic between fixed IPs behind same router

This fixes a bug where an iptables rule to not snat traffic between
fixed IPs is only being added if enable_snat=true. We should add
this rule no matter what the value is for enable_snat.

Without this patch, current code will break such use case:
2 fixed IPs behind same router both have floatingip associated. And
the router has enable_snat=false. When fixed IP A want to ping
fixed IP B, fixed IP A will get the reply from fixed IP B's floating
IP.

More details could be found at bug description.

Change-Id: I322e8d454ef1d529ceda541fb5fe577cd70b412f
Closes-bug: #1505781
neutron/agent/l3/router_info.py
neutron/tests/unit/agent/l3/test_agent.py