]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
Make DhcpRpcCallback a separate callback class
authorAkihiro Motoki <motoki@da.jp.nec.com>
Mon, 18 Aug 2014 19:14:31 +0000 (04:14 +0900)
committerAkihiro Motoki <motoki@da.jp.nec.com>
Thu, 28 Aug 2014 14:25:32 +0000 (14:25 +0000)
commit42a8770a49e0342acffa7fdde22655c98e783184
tree8f60511a85ce264853e4c91cfc528c01eb54205b
parentfed5dcf5eef78669e30995f4af7a4be94829881b
Make DhcpRpcCallback a separate callback class

RPC has a version of itself. In Neutron a plugin implements
several RPC interface, so a single RPC version doesn't work.
In Mixin callback class approach, RPC versioning depends on
each plugin implementation and it makes harder to maintain
RPC version appropriately. This patch series replaces mixin
RPC callback of server side with a separate class.

This commit handles server-side callback of dhcp-agent RPC interface.
DHCP-agent server-side callback class is moved from db/ to
api/rpc/handlers because it doesn't involve any db operations
and defining all RPC interfaces in a single place sounds reasonable.

Note that moving other DHCP-agent related RPC interface class
to api/rpc/handlers can be done in a separate patch as this patch
focuses on reorganizing the server-side RPC callback class.

Partial-Bug: #1359416
Change-Id: Ifb2a1bc0b7971995aae2856c9d4cd88c6dbc22d6
20 files changed:
neutron/api/rpc/handlers/dhcp_rpc.py [moved from neutron/db/dhcp_rpc_base.py with 97% similarity]
neutron/plugins/bigswitch/plugin.py
neutron/plugins/brocade/NeutronPlugin.py
neutron/plugins/cisco/n1kv/n1kv_neutron_plugin.py
neutron/plugins/hyperv/hyperv_neutron_plugin.py
neutron/plugins/hyperv/rpc_callbacks.py
neutron/plugins/linuxbridge/lb_neutron_plugin.py
neutron/plugins/midonet/plugin.py
neutron/plugins/ml2/plugin.py
neutron/plugins/ml2/rpc.py
neutron/plugins/mlnx/mlnx_plugin.py
neutron/plugins/mlnx/rpc_callbacks.py
neutron/plugins/nec/nec_plugin.py
neutron/plugins/oneconvergence/plugin.py
neutron/plugins/openvswitch/ovs_neutron_plugin.py
neutron/plugins/ryu/ryu_neutron_plugin.py
neutron/plugins/vmware/dhcp_meta/rpc.py
neutron/plugins/vmware/dhcpmeta_modes.py
neutron/tests/unit/openvswitch/test_agent_scheduler.py
neutron/tests/unit/test_dhcp_rpc.py [moved from neutron/tests/unit/test_db_rpc_base.py with 97% similarity]