]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commit
IBMNAS: Remove call to set r/w permissions to all
authorNilesh Bhosale <nilesh.bhosale@in.ibm.com>
Sun, 24 Aug 2014 07:36:29 +0000 (13:06 +0530)
committerJay S. Bryant <jsbryant@us.ibm.com>
Mon, 15 Sep 2014 21:05:01 +0000 (16:05 -0500)
commit3fff55681739872ab125aa7f0677f7d836c10615
tree15327119e6e53e439a92ac6d7790d26500f99a73
parent58eda5d1f41082a7e1ffef66239be30b8ac1321a
IBMNAS: Remove call to set r/w permissions to all

During cinder volume create operation from a volume snapshot or
from an existing volume (volume clone operation), the ibmnas
driver sets 'rw' permissions to all, which is unnecessary and
also poses security concerns.
Fixing this issue, removing the calls to set rw permissions to
all during these operations and adding a call to set 'rw'
permissions only to the owner to make sure even if umask is set
at the filesystem level, which might deny 'rw' access to the owner
we explicitely set the required permissions on the volume file.

Change-Id: I0e5ba9262a298e088f7724ddeda3537afa4b023e
Closes-Bug: #1367238
cinder/tests/test_ibmnas.py
cinder/volume/drivers/ibm/ibmnas.py
cinder/volume/drivers/remotefs.py