]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
Do not raise NEW exceptions
authorSergey Vilgelm <svilgelm@mirantis.com>
Mon, 24 Jun 2013 11:26:50 +0000 (15:26 +0400)
committerSergey Vilgelm <svilgelm@mirantis.com>
Tue, 25 Jun 2013 08:27:04 +0000 (12:27 +0400)
commit3ecd1cbbc95f5dacfd6503818e2c00f394f2c82d
treef768c6a3ea29bb22f19b430aa72d52860e3438dd
parentf287194b9513a6c7851e9fa44c70c94b1067867b
Do not raise NEW exceptions

Raising NEW exception is bad practice, because we lose TraceBack.
So all places like:

except SomeException as e:
    raise e

should be replaced by

except SomeException:
    raise

If we are doing some other actions before reraising we should
store information about exception then do all actions and then
reraise it. This is caused by eventlet bug. It lost information
about exception if it switch threads.

fixes bug 1191730

Change-Id: Id4aaadde7e69f0bc087cf6d96bb041d53feb131d
quantum/db/db_base_plugin_v2.py
quantum/plugins/cisco/nexus/cisco_nexus_network_driver_v2.py
quantum/plugins/cisco/nexus/cisco_nexus_plugin_v2.py
quantum/plugins/nicira/QuantumPlugin.py
quantum/plugins/nicira/api_client/request.py