]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commit
Add hacking check for explicit import of _
authorJay S. Bryant <jsbryant@us.ibm.com>
Thu, 24 Jul 2014 20:05:33 +0000 (15:05 -0500)
committerJay S. Bryant <jsbryant@us.ibm.com>
Thu, 24 Jul 2014 20:07:58 +0000 (15:07 -0500)
commit3e2b1117291d28e34e5f1391287ae1daebc74259
tree73a0600641e66695bc611a43764ce13e2d4e5495
parent8e72357c2113534e7978f3735fba99d03a9eed30
Add hacking check for explicit import of _

Unit tests are not guaranteed to discover whether
the _() function has been explicitly imported to a file.

To ensure that people do not add messages with _() translations
without importing the function, I am adding this hacking check
to enforce the import of _ when it is needed.

The commit includes fixes for offenders found by the new
check.

Change-Id: I616dce6a9da461b3ad2cfaf5e114a2aaa8ced9fa
Closes-Bug: #1348129
cinder/api/middleware/auth.py
cinder/hacking/checks.py
cinder/tests/test_backup_swift.py
cinder/tests/test_hacking.py
cinder/volume/drivers/nimble.py
cinder/zonemanager/utils.py