]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
blueprint cisco-plugin-exception-handling
authorDane LeBlanc <leblancd@cisco.com>
Wed, 10 Apr 2013 22:23:37 +0000 (18:23 -0400)
committerDane LeBlanc <leblancd@cisco.com>
Mon, 6 May 2013 15:59:33 +0000 (11:59 -0400)
commit3ba9b9873cec0571c4657af48fed9365050c49cc
tree0d18aace80d88b4505086646f4e80747506bc869
parentd4f31791c0c0eede7f6a488803daef67c68be06f
blueprint cisco-plugin-exception-handling

Improvements to exception handling in the Cisco plugins. Changes
include:

- Added mapping of Cisco exceptions to HTTP codes
  (extension to FAULT_MAP).
- Removed several unused Cisco exception definitions.
- Added several new Cisco exceptions for fault conditions.
- Added several rollbacks for various sequential operations, e.g.:
  * Create port: Nexus sub-plugin fails after OVS sub-plugin success
  * Create port: Nexus switch conig fails after adding binding to
                 Nexus binding database
  * Delete port: OVS sub-plugin fails after Nexus sub-plugin success
- Delete Port: Reversed order of OVS/Nexus sub-plugin calls so that
  it is done in the reverse order as is done for create port.
- Removed several empty except/raise blocks
- Delete network: Removed call to Nexus sub-plugin delete_network,
  since that is a no-op.
- Removed a block of unused code in model's create_network method.
- Added several unit testcases, including patching of OVS, Cisco
  and Nexus config.
- Remove CISCO_TEST configuration from cisco plugin
  config .ini file.

Change-Id: Iabdf4842aa2f0b090a90e2c565848290832b5197
quantum/plugins/cisco/common/cisco_exceptions.py
quantum/plugins/cisco/common/config.py
quantum/plugins/cisco/db/nexus_models_v2.py
quantum/plugins/cisco/models/virt_phy_sw_v2.py
quantum/plugins/cisco/network_plugin.py
quantum/plugins/cisco/nexus/cisco_nexus_network_driver_v2.py
quantum/plugins/cisco/nexus/cisco_nexus_plugin_v2.py
quantum/tests/unit/cisco/test_network_plugin.py