]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commit
Remove useless response checks in SolidFire driver
authorJohn Griffith <john.griffith8@gmail.com>
Wed, 2 Sep 2015 15:56:15 +0000 (15:56 +0000)
committerJohn Griffith <john.griffith8@gmail.com>
Wed, 2 Sep 2015 15:58:49 +0000 (15:58 +0000)
commit3b90fc7e9728c7eda45cf50259e6c5d249b5d4c9
tree0c2125940c8dd148b047c13ce6bac80230f881de
parent0773a4130d701f3b840f404bbee7adca89b69cdc
Remove useless response checks in SolidFire driver

The main issue_api_request method in the SolidFire driver
has had a mechanism to check validity of response data for
some time now.  It checks the response and if there isn't
a valid result in the response it raises.

The problem is that we still have some cruft from the old
code that does local checking/verfication.  These checks
won't ever actually be called because of the exception, and
they create some confusion.

This patch just removes those useless checks and cleans up
the api_request calls a bit.

Change-Id: Ifbcda0f943bb0b9dc47aff25bbb9245ce361fc48
Closes-Bug: #1491485
cinder/tests/unit/test_solidfire.py
cinder/volume/drivers/solidfire.py