]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commit
Create iSCSI lio portals with right IPs and port
authorGorka Eguileor <geguileo@redhat.com>
Wed, 4 Mar 2015 13:24:25 +0000 (14:24 +0100)
committerGorka Eguileor <geguileo@redhat.com>
Wed, 27 May 2015 13:40:07 +0000 (15:40 +0200)
commit3abc1d2f63730638abc0344989ccb277b8212642
tree92c441114a4fd33ad911ac21947a907f6b83741f
parent7ed2476311503b36cbab6102e082ffcfbfeb35c9
Create iSCSI lio portals with right IPs and port

Currently lioadm helper creates portals with fixed IP addresses 0.0.0.0
and ::0 and also uses fixed standard port 3260 instead of using store
configuration (iscsi_ip_address, iscsi_secondary_ip_addresses,
iscsi_port) from the configuration as it should.

This could lead to problems if a different port was defined in the
configuration as the target would be available only on 3260 and other
services would look for it at configured port.

With this fix we now create the right portals with the right port.

Since now we pass list of ips and port to helpers cxt helper has also
been updated to use these parameters instead of going directly to the
configuration.

Change-Id: I77e8865b1f015a9fa155f2b4552a5d9c27f5e122
Closes-Bug: #1425875
cinder/cmd/rtstool.py
cinder/tests/unit/targets/targets_fixture.py
cinder/tests/unit/targets/test_cxt_driver.py
cinder/tests/unit/targets/test_iet_driver.py
cinder/tests/unit/targets/test_lio_driver.py
cinder/tests/unit/targets/test_tgt_driver.py
cinder/tests/unit/test_cmd.py
cinder/volume/targets/cxt.py
cinder/volume/targets/iscsi.py
cinder/volume/targets/lio.py