]> review.fuel-infra Code Review - puppet-modules/puppetlabs-firewall.git/commit
(MODULES-6029) Skip unparsable rules with warning
authorJiri Stransky <jistr@redhat.com>
Thu, 23 Nov 2017 14:11:03 +0000 (15:11 +0100)
committerJiri Stransky <jistr@redhat.com>
Thu, 23 Nov 2017 14:11:03 +0000 (15:11 +0100)
commit3a9a1f7b6ef5ed5065d97ef02f69b37ca35a7110
tree59f8d5b410c8f46eafa29f01ae54bc449f327948
parente653c3f894844b49f67a3784ce2d981dcb56ca8f
(MODULES-6029) Skip unparsable rules with warning

The iptables rules parser has very strict/simplistic expectations
about how iptables rules should look like, and can easily fail to
parse rules that weren't produced by the module itself.

We should ignore the unfitting rules when parsing and produce a
warning rather than causing a fatal error and stopping the Puppet run.
lib/puppet/provider/firewall/iptables.rb
spec/fixtures/iptables/conversion_hash.rb
spec/unit/puppet/provider/iptables_spec.rb