]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commit
Dont set error_extending status on API extend call
authorjohn-griffith <john.griffith@solidfire.com>
Sat, 8 Feb 2014 04:55:22 +0000 (21:55 -0700)
committerjohn-griffith <john.griffith@solidfire.com>
Sat, 8 Feb 2014 04:58:53 +0000 (21:58 -0700)
commit3a4153e5f256fb5c7c308815c2314d427c31864b
treec9202e225fed3f2dc02509e857ff6357400e9240
parente8feb702f6953db86f45c4c28ce4182e2e22377c
Dont set error_extending status on API extend call

Recent change (Ifd523ac5e9039861cf87711dc5c4842b5cb524c2)
moved the quota check on extend_volume to the API layer
in order to provide feedback to caller if the quota check
failed.

The problem is that change still sets the volume status to
error_extending if the quota check fails.  There's no reason
to do this if we're now giving immediate feedback that the call
failed.

I'm also unclear on what the purpose of adding the reservations
to the rpc call are, but I'll double check on that before changing.

This patch leaves most of the previous change in place but
removes the setting of error_extending to the volumes status
on the quota fail.

Change-Id: I8521c876b8d5c344713f211fa0c8c0c58a12a879
cinder/volume/api.py