]> review.fuel-infra Code Review - puppet-modules/puppetlabs-firewall.git/commit
(#10002) Change to dport and sport to handle ranges, and fix handling of name to...
authorKen Barber <ken@bob.sh>
Tue, 11 Oct 2011 17:29:17 +0000 (18:29 +0100)
committerKen Barber <ken@bob.sh>
Wed, 26 Oct 2011 01:21:44 +0000 (02:21 +0100)
commit3991b7621c10254b2ad7508375bc93e68133fa12
tree17e941c9e7a7674434b1cd8443bb5f24fd457dbf
parent5abf102914d5738ab1ea0a6b53837505ec79ff96
(#10002) Change to dport and sport to handle ranges, and fix handling of name to port.

We hadn't been allowing ranges of the kind 22:1000 for ranges. This patch
fixes that. Thanks to Jason Hancock for finding this issue and providing a sample
patch.

Instead of using colon though, it was decided we would use a hyphen to specify a range
as its more agnostic. This patch does the filtering for both writing the rule and
reading the rule.

Also - the way we were doing name to port conversion had been broken. I found
this out while fixing the ranges, and have now fixed it and added tests.
lib/puppet/provider/firewall/iptables.rb
lib/puppet/type/firewall.rb
lib/puppet/util/firewall.rb
spec/fixtures/iptables/conversion_hash.rb
spec/unit/puppet/type/firewall_spec.rb