]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
Remove is_active property from SimpleInterfaceMonitor
authorrossella <rsblendido@suse.com>
Thu, 23 Apr 2015 22:57:18 +0000 (22:57 +0000)
committerrossella <rsblendido@suse.com>
Wed, 29 Apr 2015 22:39:10 +0000 (22:39 +0000)
commit3543d8858691c1a709127e25fc0838e054bd34ef
treeea5b36796d2f4750861880dcc0a28a45bb464328
parent2023ed2336f789b3370383b20d7efcf7a577975e
Remove is_active property from SimpleInterfaceMonitor

is_active property from SimpleInterfaceMonitor shadows
the method is_active inherited from AsyncProcess.
The property checks that ovsdb monitor is running and
that it received some data. When ovsdb monitor starts
it always receives data, since it processes the interfaces
present on the machine, so the flag data_received will
always be set to true right after SimpleInterfaceMonitor
starts. Considering that, is_active can be removed and
the method is_active inherited from AsyncProcess can be
used instead.

Change-Id: I05faeddd061ab45af51c044a10462c3a57593d4d
neutron/agent/linux/ovsdb_monitor.py
neutron/tests/functional/agent/linux/test_ovsdb_monitor.py
neutron/tests/unit/agent/linux/test_ovsdb_monitor.py