]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commit
Fix the generalized copy_image_to_volume operation.
authorjohn-griffith <john.griffith@solidfire.com>
Fri, 1 Feb 2013 05:38:51 +0000 (22:38 -0700)
committerjohn-griffith <john.griffith@solidfire.com>
Fri, 1 Feb 2013 05:43:19 +0000 (22:43 -0700)
commit31e481667db8b98442f69b478b8aa4a18437b191
treef628b14b9967a40d6f33c4804161bcaaa6639856
parent03f759c4ad28b30574168adb94d7f9a7b4cd3dc2
Fix the generalized copy_image_to_volume operation.

The Generis iSCSI copy volume<->image patch
(change: Iff097629bcce9154829a7eb5aee0ea6302338b26) did
not account for the fact that the existing volume reference
passed in to the copy method would not have the updated
provider_location and iSCSI info available.

To address this, we simply just get a new ref from the DB
after creation if a copy image is requested.

Also, the list of acceptable formats was not fully inclusive,
not only that, but there's no reason to not let the qemu-convert
handle any errors here.

Change-Id: I7b1910080d285562c7f2d8afa7f65768b1089b73
cinder/volume/api.py
cinder/volume/manager.py