]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
Fix intermittent UT failures in test_utils
authorarmando-migliaccio <armamig@gmail.com>
Tue, 7 Apr 2015 22:37:59 +0000 (15:37 -0700)
committerarmando-migliaccio <armamig@gmail.com>
Tue, 7 Apr 2015 23:40:47 +0000 (16:40 -0700)
commit31631e82bbf974c50fb913dafe0ad86e2c0e6a8b
tree02de5812cd674a61944359c54f9ea2b24d954377
parent7f143e75ee84514aeb01acced927aa5ead7f8d42
Fix intermittent UT failures in test_utils

Change eba4c2941ee introduced these tests. However they are not that useful as they
simply mimick the code, without really ensuring that the behavior is expected, so
they provide negative value ([1]), plus, they fail randomly.

This patch removes them in favor of a more useful functional check.

[1] http://googletesting.blogspot.com/2015/01/testing-on-toilet-change-detector-tests.html

Closes-bug: #1441347

Change-Id: I8a321995295deef7f6d30be303486be491e2771f
neutron/tests/functional/agent/linux/test_process_monitor.py
neutron/tests/unit/agent/linux/test_utils.py