]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
Removing sorted() function from assertEqual()
authorEvgeny Fedoruk <evgenyf@radware.com>
Tue, 12 Aug 2014 11:13:24 +0000 (04:13 -0700)
committerEvgeny Fedoruk <evgenyf@radware.com>
Sun, 24 Aug 2014 06:35:59 +0000 (23:35 -0700)
commit3082a074f819f0479fc941b30dc7cfdbb8aab394
treedf37ec20594fdcfc470aa1065c9d2a9dedcb80b1
parent4b3547c28c244f70803de9dc47d767f80b7ec2dc
Removing sorted() function from assertEqual()

Removing unnecessary sorted() function from assertEqual() function
calls in functions used for sorting and pagination testing

Using sorted() breaks sorting tests objective which is to test sorting.
This is causing every unit test using this functions
(_test_list_with_sort, _test_list_with_pagination, _test_list_with_pagination_reverse)
for sorting tests to always succeed

Switched the parameters for assertEqual() function within the fixed code to meet
its signature - assertEqual(self, expected, observed, message='')

Test neutron.tests.unit.vmware.vshield.test_lbaas_plugin.TestLoadbalancerPlugin.test_list_vips
was succeeding because of this bug, although it should fail. It failed after the bug was fix.
Test was fixed.

Change-Id: Ia36b81d9a7fd32cae3b567ac1899b56481eb62ce
Closes-Bug: #1355251
neutron/tests/unit/test_db_plugin.py
neutron/tests/unit/vmware/vshield/test_lbaas_plugin.py