]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
Refactor router delete processing
authorRyan Moats <rmoats@us.ibm.com>
Mon, 30 Nov 2015 18:36:54 +0000 (12:36 -0600)
committerRYAN D. MOATS <rmoats@us.ibm.com>
Fri, 15 Jan 2016 15:37:37 +0000 (09:37 -0600)
commit300f73d489ce0131035bac59a1f12787e20bf3ab
treec93ea4a71d1ddf80dfbc606c25d097e90201bf91
parent2c599814fbf7f13504218000c07de81eb6f25f5a
Refactor router delete processing

The discussion in [2] indicated that [1] would lead to orphaned
items during error cases.  This refactoring replaces the
optimistic approach followed by [1] with a separate delete code
path that does not execute the operations that take place within
the namespace that will be removed.  Operations that take place
outside of those namespaces are still performed to ensure that
no orphaned items result.

A comment has been added to the functional test to explain what
case is being tested.

[1] https://review.openstack.org/#/c/240971
[2] conversation starting at http://goo.gl/bZgvqW

Change-Id: I663f1264fb3963789b79a4a7c3e46d232b2f0620
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>
neutron/agent/l3/dvr_edge_ha_router.py
neutron/agent/l3/dvr_local_router.py
neutron/agent/l3/dvr_router_base.py
neutron/agent/l3/ha_router.py
neutron/agent/l3/router_info.py
neutron/tests/functional/agent/l3/test_dvr_router.py