]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
Code Review / openstack-build / neutron-build.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: 2b37bf1) | patch
Prefer "val !=/== ref" over "val (not) in [ref]" in conditions
authorCedric Brandily <zzelle@gmail.com>
Tue, 26 Aug 2014 17:45:22 +0000 (19:45 +0200)
committerCedric Brandily <zzelle@gmail.com>
Tue, 26 Aug 2014 17:58:58 +0000 (19:58 +0200)
commit2f717b83996d78198868dd93af5740af199e81f8
treef6e6b4c3eba32b519b246bea4f59936a4ff05794tree | snapshot
parent2b37bf185981b8e068fc896ad569dbe1f90e548fcommit | diff
Prefer "val !=/== ref" over "val (not) in [ref]" in conditions

This change increases readibility with the following replacements in
conditions:

 * val in [ref] ==> val == ref
 * val not in [ref] ==> val != ref

Change-Id: I52a77aff60c8e46fa5f6290e3a565f58425d9a68
neutron/plugins/ml2/drivers/type_local.py diff | blob | history
neutron/services/firewall/fwaas_plugin.py diff | blob | history
neutron/services/loadbalancer/drivers/radware/driver.py diff | blob | history