]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
Remove SELECT FOR UPDATE use in update_firewall
authorCedric Brandily <zzelle@gmail.com>
Tue, 26 Aug 2014 20:57:30 +0000 (22:57 +0200)
committerCedric Brandily <zzelle@gmail.com>
Wed, 27 Aug 2014 09:29:24 +0000 (11:29 +0200)
commit2ce3525286eb5e0cf30c72a91f33dccb50e518b0
treed337dcd97d7ae5bd454a1a9495b0442680b0e5d9
parent2f7932055247df3ac5ec4783e029cfeda0466f71
Remove SELECT FOR UPDATE use in update_firewall

SELECT FOR UPDATE expression, which is triggered with the use of the
SQLAlchemy Query object's with_lockmode('update') method, is
detrimental to performance and scalability of the database
performance code in Neutron due to the lock contention it produces.

SELECT FOR UPDATE can be entirely avoided in update_firewall method
with the use of single-shot UPDATE expressions.

Change-Id: I333f726498192295116ca96ff5ca9012c36a6fd1
neutron/db/firewall/firewall_db.py