]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
Openvswitch update_port should return updated port info
authorJon Grimm <jgrimm@linux.vnet.ibm.com>
Wed, 27 Nov 2013 19:10:33 +0000 (13:10 -0600)
committerJon Grimm <jgrimm@linux.vnet.ibm.com>
Fri, 28 Feb 2014 18:44:36 +0000 (12:44 -0600)
commit2cbded6e836e0b20b23384eb26252eda58298259
treeaed1ca0e1fd6d8a123e4040a40da2a1cdfa8a313
parent66f66566d8703dd27cb101b620571dc0e9d30083
Openvswitch update_port should return updated port info

Found when I enabled test_extension_allowedaddress_pairs, where
test_create_port_removed_allowed_address_pairs would fail due to the
returned port still containing the original addresspair.  The cause is
ovs simply not updating the port info being returned.

This patch additionally enables test_extension_allowedaddress_pairs for
openvswitch.

Moved checks and updating into method similar to what we do for
extradhcpopts and security_groups.

Additionally, this required fixing is_address_pairs_attribute_updated() as
it was passing (non-hashable) dicts to utils.compare_elements.

Change-Id: Ic871fea68fb9fcc862b1fd5ae5fe7aec540e4a30
Partial-Bug: #1255150
neutron/db/allowedaddresspairs_db.py
neutron/plugins/openvswitch/ovs_neutron_plugin.py
neutron/tests/unit/openvswitch/test_openvswitch_plugin.py