]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
Removes the use of mutables as default args
authorGary Kotton <gkotton@vmware.com>
Thu, 29 Oct 2015 14:40:05 +0000 (07:40 -0700)
committerGary Kotton <gkotton@vmware.com>
Thu, 29 Oct 2015 14:57:31 +0000 (07:57 -0700)
commit2b7fb6ff08a49618ee441f80b07bd622e1ee0b1b
tree6a1be037d56eb5f57eb26016114a3b5eaa6beef3
parent6af52340ff1da075e0b03b089d24d197e33ece3f
Removes the use of mutables as default args

Passing mutable objects as default args is a known Python pitfall.
We'd better avoid this. This commit changes mutable default args with
None, then use 'arg = arg or {}', 'arg = arg or []'. For unit code which
doesn't use the args , just set with None. This commit also adds hacking
check.

This code was taken from commit 0bea84ac20fe498bd08f7212a0017196c8cb0812
in Nova.

Change-Id: I36d07cade687690dc02a8f6cc3d70f5d00caf112
Co-Authored-By: ChangBo Guo(gcb) <glongwave@gmail.com>
17 files changed:
HACKING.rst
neutron/agent/linux/interface.py
neutron/agent/linux/iptables_firewall.py
neutron/api/api_common.py
neutron/api/extensions.py
neutron/hacking/checks.py
neutron/plugins/ml2/drivers/mech_sriov/agent/sriov_nic_agent.py
neutron/tests/unit/agent/linux/test_interface.py
neutron/tests/unit/api/test_extensions.py
neutron/tests/unit/api/v2/test_base.py
neutron/tests/unit/db/test_db_base_plugin_v2.py
neutron/tests/unit/extension_stubs.py
neutron/tests/unit/extensions/test_dns.py
neutron/tests/unit/extensions/test_l3.py
neutron/tests/unit/extensions/test_securitygroup.py
neutron/tests/unit/hacking/test_checks.py
neutron/tests/unit/plugins/ml2/drivers/freescale/test_mechanism_fslsdn.py