]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
Do not assume order of report list elements
authorjohndavidge <jodavidg@cisco.com>
Fri, 8 Aug 2014 11:48:59 +0000 (04:48 -0700)
committerJohn Davidge <jodavidg@cisco.com>
Mon, 29 Sep 2014 11:00:51 +0000 (11:00 +0000)
commit2abb77b4dadd4150f554f134ec99b07c2b28900f
tree98a785741a9fff7e904e3959de33810b6cc1d8c0
parentff9745c9527399df52f56b022a698cd63e48d537
Do not assume order of report list elements

This fixes the test_report_multiple_services unit test that breaks with a
randomized PYTHONHASHSEED (see the bug report).

The test assumed that the report list from self.driver.report_status() had
elements in a particular order. Found with PYTHONHASHSEED=2455351445.

The fix refactors the test case to handle an unsorted report list by
sorting it before checking equality.

Partial-bug: #1348818

Note: There are several other unrelated unit tests that also break with a
randomized PYTHONHASHSEED, but they are not addressed here. They will be
addressed in separate patches.

Change-Id: I542c3818821fa2f6e460fd254a3842530ecea8d9
neutron/tests/unit/services/vpn/device_drivers/test_cisco_ipsec.py