]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commit
Don't send heartbeats if Manager reports a problem
authorMichal Dulko <michal.dulko@intel.com>
Thu, 4 Jun 2015 15:25:24 +0000 (17:25 +0200)
committerMichal Dulko <michal.dulko@intel.com>
Thu, 4 Jun 2015 15:25:24 +0000 (17:25 +0200)
commit2a84ae0fc015a43617521727ca31152066839d3c
tree9b6eb8624b1448aea3d9bd63757dfe3f013c0813
parent376f972362b8b35d6698db326248c66eda881e8f
Don't send heartbeats if Manager reports a problem

This commit adds is_working method to base Manager class that can be
used to indicate that service has some problems and isn't running
correctly. This is used to block refreshing Service heartbeats if
Manager will return False from is_working.

The method is implemented in c-vol Manager to return initialization
state of the underlying volume driver.

Closes-Bug: 1446750
DocImpact

Change-Id: I809b2b777a0f84d12f39f2233920ec961f74f846
cinder/manager.py
cinder/service.py
cinder/tests/unit/test_service.py
cinder/tests/unit/test_volume.py
cinder/volume/manager.py