]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
Reorder operations in (l3_dvr) update floating ip
authormarios <marios@redhat.com>
Wed, 22 Oct 2014 10:11:02 +0000 (13:11 +0300)
committermarios <marios@redhat.com>
Tue, 28 Oct 2014 14:22:12 +0000 (16:22 +0200)
commit280b9eacb7be2db2d9d2fd5cafad2814f07ac70c
tree2284015782c66d7531cf715110b669310b13b2ce
parent4a28612f60f863ac97d67d4ee48fe8ac8345966d
Reorder operations in (l3_dvr) update floating ip

This review overrides update_floatingip (L3_NAT_dbonly_mixin)
in l3_dvr_db (L3_NAT_with_dvr_db_mixin) to reorder the garbage
collection to after the floating ip is updated and rpc called.
This was previously being called in the (already) overridden
_update_fip_assoc.

Since this call is moved, the _update_fip_assoc for l3_dvr_db
is exactly the same as l3_db and is thus removed completely.

This tidy up was created whilst looking at bug 1381617. The
intention was to mitigate the timing issues exposed by [1]
and discussed in the bug report. It seems the problem persists
with more discussion around 'properly fixing' this at [2].

[1] https://review.openstack.org/#/c/102700/
[2] https://review.openstack.org/#/c/130414/4

Change-Id: I24cef57bf394ceeb931ff48fa67f18218c734b00
neutron/db/l3_dvr_db.py