]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
Improve unit test coverage for Cisco plugin nexus code
authorDane LeBlanc <leblancd@cisco.com>
Thu, 21 Nov 2013 18:13:02 +0000 (13:13 -0500)
committerDane LeBlanc <leblancd@cisco.com>
Mon, 25 Nov 2013 22:24:17 +0000 (17:24 -0500)
commit26e9fad61f86bedd16179ede9736b56c4a9a5752
tree8a1b20247296001eb48a706bafa84910d0bbfc85
parenta0a462f0303f68d885ff344898437e310c64188c
Improve unit test coverage for Cisco plugin nexus code

Closes-Bug: #1190622

This fix improves the unit test coverage for the Cisco Nexus plugin's
cisco_nexus_network_driver_v2.py and cisco_nexus_plugin_v2.py
source files from:
cisco_nexus_network_driver_v2: 72%
cisco_nexus_plugin_v2:         79%
To:
cisco_nexus_network_driver_v2: 99%
cisco_nexus_plugin_v2:         94%

Much of what the remaining "uncovered" code (coverage tool
reports as partially covered) can be attributed to the
coverage tool not being aware that execution does not
continue at the end of a save_and_reraise_exception()
context block (i.e. the exception will be reraised, but
the coverage tool isn't aware of this).

This fix and coverage results are dependent on the fix for #1246080.

Change-Id: Ie0e11fc0a12502739fb39bb4b30deb04dd31b7b0
neutron/plugins/cisco/l2device_plugin_base.py
neutron/plugins/cisco/nexus/cisco_nexus_network_driver_v2.py
neutron/plugins/cisco/nexus/cisco_nexus_plugin_v2.py
neutron/plugins/cisco/nexus/cisco_nexus_snippets.py
neutron/plugins/cisco/test/nexus/fake_nexus_driver.py
neutron/tests/unit/cisco/test_network_plugin.py
neutron/tests/unit/cisco/test_nexus_plugin.py