]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
Fix 'null' response on router-interface-remove operation
authorarmando-migliaccio <amigliaccio@nicira.com>
Tue, 30 Apr 2013 23:19:04 +0000 (16:19 -0700)
committerarmando-migliaccio <amigliaccio@nicira.com>
Tue, 30 Apr 2013 23:50:56 +0000 (16:50 -0700)
commit2516c136549195a92a20aa6570e27af5dfbef28a
tree2ac3dd5e7504975ad9338f8cf27473a1af8dfd25
parentdbae68c3604c3b16ef8be001131fd6f4cbb278b0
Fix 'null' response on router-interface-remove operation

To avoid a 'null' response body, the delete operation returns a response
that is consistent with its add counterpart, i.e. we return the router
id with details about the interface being affected by the operation, as
well as the tenant id.

A unit test is added to ensure that the right body is returned and minor
adjustments have been made to the plugins affected by the change.

Long-term, a delete operation should really return 204 w/o a body, but
this requires some major rework of the WSGI handling within Quantum.
This is an interim solution that deals with an 'ugly' response body,
whilst keeping backward compatibility.

Fixes bug 1173284

Change-Id: Icaab87ad0c8561c0690c8f0a14db815d8886bc71
quantum/db/l3_db.py
quantum/plugins/midonet/plugin.py
quantum/plugins/nicira/QuantumPlugin.py
quantum/tests/unit/test_l3_plugin.py