]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commit
Address potential races in SolidFire VAG
authorChris Morrell <chris@solidfire.com>
Wed, 2 Dec 2015 22:27:37 +0000 (22:27 +0000)
committerChris Morrell <chris@solidfire.com>
Thu, 3 Dec 2015 19:02:29 +0000 (19:02 +0000)
commit250127530e5d66ea0403bc0ea58fa60fe5699657
tree84c7381f027eb9b4deadb8600e1a0b79aa026dd2
parent23bfbd04070c31c83d3831dc8c64c1fc4ba79ac2
Address potential races in SolidFire VAG

While building the initial volume access group solution I realized there were
race conditions present. This patch attempts to address those by being far
more careful during VAG creation and removal. Tracking multiattach volume
detaches around VAG volume removal introduced all sorts of future race
conditions so instead multiattach volumes are treated differently and are only
removed from VAGs on volume removal. Not ideal but it'll get the job done.

Think I covered all the new branches with unit tests. Complexity was introduced
but it should be worth it due to the safety that was also introduced.

Change-Id: I80034cdf759295c8d379c02ed9e42659590b41a9
cinder/tests/unit/test_solidfire.py
cinder/volume/drivers/solidfire.py