]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
Document self.assertEqual(expected, observed) pattern
authorCedric Brandily <zzelle@gmail.com>
Mon, 5 Oct 2015 19:59:44 +0000 (21:59 +0200)
committerCedric Brandily <zzelle@gmail.com>
Mon, 5 Oct 2015 23:03:53 +0000 (01:03 +0200)
commit2429dd917fbb5f69efc0e0b2ff86e3409724fac3
treec4cba3303f5c8f092a65eeedf16f64745f0111f5
parent49746ca4749c45d2772289061f161145eb5ad2b8
Document self.assertEqual(expected, observed) pattern

Tests should use the following pattern to help reviewers:

  self.assertEqual(expected, observed)

This change documents it in effective_neutron.rst and corrects some test
modules[1] including nonobvious ones[2] as an example.

[1] neutron.tests.unit.agent.l3.test_.*
[2] neutron.tests.unit.agent.l3.test_router_processing_queue

Change-Id: I6d6363541e3fef6f66e808aab00507825205b209
doc/source/devref/effective_neutron.rst
neutron/tests/unit/agent/l3/test_agent.py
neutron/tests/unit/agent/l3/test_dvr_fip_ns.py
neutron/tests/unit/agent/l3/test_namespace_manager.py
neutron/tests/unit/agent/l3/test_router_processing_queue.py