]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commit
Code Review / openstack-build / cinder-build.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: 2f3384c) | patch
Fix use of invalid variable in tgt exists check
authorJohn Griffith <john.griffith8@gmail.com>
Wed, 3 Dec 2014 17:44:49 +0000 (10:44 -0700)
committerJohn Griffith <john.griffith8@gmail.com>
Fri, 12 Dec 2014 05:36:03 +0000 (05:36 +0000)
commit22abe9081543bde315f39438e56eb7ce8c30c223
tree3210789818cbbaa74cba8bc443ff1470c05836cdtree | snapshot
parent2f3384c0a53b100c2357f4b2ac7e79eea6858dd9commit | diff
Fix use of invalid variable in tgt exists check

I added a check for tgt already exists here:
https://review.openstack.org/#/c/138173/

But, that was wrong, the err value is never going to be
set because of the exception.  This should have inspected
the exception object and checked against it.

So this patch makes it do what it was supposed to do.

Change-Id: I8c184bf1684c8592a36f749cdcb5493f6b65e52b
cinder/brick/iscsi/iscsi.py diff | blob | history