review.fuel-infra Code Review - openstack-build/cinder-build.git/commit

]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commit

Code Review / openstack-build / cinder-build.git / commit

author	Ivan Kolodyazhny <e0ne@e0ne.info>
	Mon, 14 Jul 2014 21:13:54 +0000 (00:13 +0300)
committer	Ivan Kolodyazhny <e0ne@e0ne.info>
	Wed, 16 Jul 2014 06:42:08 +0000 (09:42 +0300)
commit	1cfb7da7ce3f93765ba2e267897b5b7825a0ba75
tree	8b9456e0cc5f69f7abf56161c62175b898b5f3ac	tree \| snapshot
parent	cfe8f2dec11dbd335028a3ba9c793f5901ef4fcf	commit \| diff

Use immutable default values for args

Default mutable values (e.g. arg1=[], arg2={}) could have side effects
in Python. So using None as a default value is safer.

Added hacking checks for default mutable args.

Closes: bug #1327473
Change-Id: I7055e534b91df794550de6c3b243324e582d4430

14 files changed:

RSS Atom

cinder/api/xmlutil.py		diff \| blob \| history
cinder/hacking/checks.py		diff \| blob \| history
cinder/scheduler/driver.py		diff \| blob \| history
cinder/scheduler/filter_scheduler.py		diff \| blob \| history
cinder/tests/api/v2/stubs.py		diff \| blob \| history
cinder/tests/brick/test_brick_connector.py		diff \| blob \| history
cinder/tests/test_coraid.py		diff \| blob \| history
cinder/tests/test_vmware_vmdk.py		diff \| blob \| history
cinder/tests/test_volume_utils.py		diff \| blob \| history
cinder/transfer/api.py		diff \| blob \| history
cinder/volume/drivers/netapp/utils.py		diff \| blob \| history
cinder/volume/drivers/vmware/vmdk.py		diff \| blob \| history
cinder/volume/qos_specs.py		diff \| blob \| history
cinder/volume/volume_types.py		diff \| blob \| history