]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commit
NetApp: Fix issue with updating E-Series password
authorMichael Price <michael.price@netapp.com>
Thu, 17 Sep 2015 20:33:37 +0000 (15:33 -0500)
committerMichael Price <michael.price@netapp.com>
Wed, 28 Oct 2015 17:43:07 +0000 (17:43 +0000)
commit1b4e2e7a48ec76fa5bc80b13fc4a04bce660ad31
tree88af0fa2f5c1dce5721bc1b4fd3365133037da98
parent170aac0ab03cc2626db0746fdc6a39fa2e775913
NetApp: Fix issue with updating E-Series password

The NetApp E-Series storage array password is specified in the
configuration file, and must be updated if the array has its password
changed via the management software. However, the logic to check
whether or not the password is currently valid was incorrect, and
was not correctly detecting an invalid password in need of updating.

This patch fixes the password validity checking for the driver,
refactors the existing code to be more concise, and adds additional
unittests around this functionality.

Change-Id: I1468d1810479947a9cff7ef8b79440de4063cbed
Closes-Bug: #1497007
cinder/tests/unit/volume/drivers/netapp/eseries/fakes.py
cinder/tests/unit/volume/drivers/netapp/eseries/test_client.py
cinder/tests/unit/volume/drivers/netapp/eseries/test_library.py
cinder/volume/drivers/netapp/eseries/client.py
cinder/volume/drivers/netapp/eseries/library.py