]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commit
Dell SC: Expanded comments and update var names
authorTom Swanson <tom_swanson@dell.com>
Tue, 2 Jun 2015 19:02:33 +0000 (14:02 -0500)
committerTom Swanson <tom_swanson@dell.com>
Tue, 9 Jun 2015 17:41:09 +0000 (12:41 -0500)
commit1991e5768e0ef47d69214063370fd527a6444f7b
tree1bb3aabf21ea13635a19fade34f28a8c9aec7a52
parent918b3c137c043c225b6e0cd51a6369a0c6b94b7e
Dell SC: Expanded comments and update var names

Additional comments have been added to help explain what is happening
in the driver. This revolves mostly around dell_storagecenter_api.py
which is not an obvious file for a reviewer to review. Hopefully
additional comments will aid this.

Updated single character variable names except for r which is the
REST calls return throughout the code by convention.

Reworked create_volume for clarity. No functional changes.

Changed two obvious error messages from LOG.debug to LOG.error.

Driver version changed to 1.0.2.

Change-Id: Ib41d9bc45d20af4fc179b691549fe52f8bd6ec6d
cinder/volume/drivers/dell/dell_storagecenter_api.py
cinder/volume/drivers/dell/dell_storagecenter_common.py
cinder/volume/drivers/dell/dell_storagecenter_fc.py
cinder/volume/drivers/dell/dell_storagecenter_iscsi.py