]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
Update rootwrap; track changes in nova/cinder
authorJohn Dunning <jrd@jrd.org>
Tue, 14 Aug 2012 18:31:47 +0000 (14:31 -0400)
committerJohn Dunning <jrd@jrd.org>
Thu, 30 Aug 2012 20:55:00 +0000 (16:55 -0400)
commit193d6997276d3efcfaf99e5fcca1354c8c8c4670
tree331f542bf690d41c67122b8bddeedbd5007cc061
parent9198ca803a3fddc91a1d45d3cd9a37b7aeca2215
Update rootwrap; track changes in nova/cinder

Fix bug 1037815

Summary: Copy/paste the essential parts of the rootwrap
  mechanism from nova/cinder into quantum.  This includes
  the core changes to filter.py and wrapper.py which deal
  with loading filters from files pointed to by
  rootwrap.conf
Detailed changes:
  Transliterate the old rootwrap/*-agent.py files to
  new format, and put the results in etc/quantum/rootwrap.d
  Delete the *-agent.py files.
  Add conf to point to etc/quantum/rootwrap.d
  Add a unit test cribbed from nova to exercise the filter
  mechanism
  Add a unit test to exercise the actual filtered execution
Note that as written, this patch does not set the default
  execute mechanism (in the agent .ini files) to rootwrap,
  leaves it as sudo.  That can be done in a followon
  change, or in distro specific packaging.
Note also that there is still work to do around finishing
  and testing the filter specs themselves.  We've decided
  that that is out of scope for this patch.

Change-Id: I9aba6adc5ba40b6145be5fa38c5ece3b666ae5ca
26 files changed:
bin/quantum-rootwrap
etc/dhcp_agent.ini
etc/l3_agent.ini
etc/quantum/plugins/linuxbridge/linuxbridge_conf.ini
etc/quantum/plugins/nec/nec.ini
etc/quantum/plugins/openvswitch/ovs_quantum_plugin.ini
etc/quantum/plugins/ryu/ryu.ini
etc/quantum/rootwrap.d/dhcp.filters [new file with mode: 0644]
etc/quantum/rootwrap.d/iptables-firewall.filters [new file with mode: 0644]
etc/quantum/rootwrap.d/l3.filters [new file with mode: 0644]
etc/quantum/rootwrap.d/linuxbridge-plugin.filters [new file with mode: 0644]
etc/quantum/rootwrap.d/nec-plugin.filters [new file with mode: 0644]
etc/quantum/rootwrap.d/openvswitch-plugin.filters [new file with mode: 0644]
etc/quantum/rootwrap.d/ryu-plugin.filters [new file with mode: 0644]
etc/rootwrap.conf [new file with mode: 0644]
quantum/rootwrap/dhcp-agent.py [deleted file]
quantum/rootwrap/filters.py
quantum/rootwrap/iptables-firewall-agent.py [deleted file]
quantum/rootwrap/linuxbridge-agent.py [deleted file]
quantum/rootwrap/openvswitch-agent.py [deleted file]
quantum/rootwrap/ryu-agent.py [deleted file]
quantum/rootwrap/wrapper.py
quantum/tests/etc/rootwrap.d/quantum.test.filters [new file with mode: 0644]
quantum/tests/unit/_test_rootwrap_exec.py [new file with mode: 0644]
quantum/tests/unit/test_rootwrap.py [new file with mode: 0644]
setup.py