]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commit
Harden scheduler.rpcapi unit tests
authorMichal Dulko <michal.dulko@intel.com>
Tue, 23 Jun 2015 13:47:53 +0000 (15:47 +0200)
committerMichal Dulko <michal.dulko@intel.com>
Tue, 23 Jun 2015 13:47:53 +0000 (15:47 +0200)
commit18c1a32e7285f12932e8fda430f9ee95f1de8ef7
tree506970f4618fab647a41c36b415efba9b66eb8b0
parent5f6cbecc5ec5b6ca034290dc7bd04ab7d956cd15
Harden scheduler.rpcapi unit tests

Tests for scheduler.rpcapi are very weak. Even changing keyword
arguments names passed to call and cast methods in this module
doesn't trigger unit tests failures. This commit adds keyword
arguments validation to prevent problems similar to ones caused
by bug 1467841 in backup.rpcapi. I've also fixed argument order
in assertEqual usages there.

Change-Id: I78d80d5c5596fb5615608f93157d4d2b3a9b0aef
Related-Bug: 1467841
cinder/tests/unit/scheduler/test_rpcapi.py