]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
Remove SELECT FOR UPDATE use in delete_firewall
authorCedric Brandily <zzelle@gmail.com>
Tue, 26 Aug 2014 18:23:04 +0000 (20:23 +0200)
committerCedric Brandily <zzelle@gmail.com>
Tue, 2 Sep 2014 12:34:23 +0000 (12:34 +0000)
commit187217d767ca41b742937fe183ba4a4c20e59185
treebe53ca5f01ddf440c0a31919bdbb5d1648fffb3b
parent2f7932055247df3ac5ec4783e029cfeda0466f71
Remove SELECT FOR UPDATE use in delete_firewall

SELECT FOR UPDATE expression, which is triggered with the use of the
SQLAlchemy Query object's with_lockmode('update') method, is
detrimental to performance and scalability of the database
performance code in Neutron due to the lock contention it produces.

SELECT FOR UPDATE can be entirely avoided in delete_firewall method
with the use of single-shot DELETE expressions.

Partial-Bug: #1364358
Change-Id: Ia8db73312f5dff6a5bd573694a60a798279834cb
neutron/db/firewall/firewall_db.py