]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commit
Storwize: Split up __init__ into separate files
authorJacob Gregor <jgregor@us.ibm.com>
Fri, 18 Dec 2015 16:27:02 +0000 (10:27 -0600)
committerJacob Gregor <jgregor@us.ibm.com>
Mon, 21 Dec 2015 17:55:35 +0000 (11:55 -0600)
commit15aee9b914702d40b9daef48737b3dc6fe8a79fb
treeac29da1bd7f3517c24cec4019a84fd0fe38df640
parent8e302a251739758ac040cea0cafc688bea8e99fd
Storwize: Split up __init__ into separate files

This patch is one in a series of patches with the aim to
bring the storwize_svc driver in line with other san based
Cinder drivers.

Currently all the iSCSI and FC code are all together in a single
file. This patch goes into the __init__.py and splits it up into
storwize_svc_iscsi.py, storwize_svc_fc.py, and storwize_svc_common.py.
This new structure is consistent with other san based drivers.

In addition, tests were also updated to reflect the changes listed
above.

Since the driver has been split into two, we need to update how
to enable each new driver. The user now needs to set different
values for volume_driver, as shown below.

FC:volume_driver=cinder.volume.drivers.ibm.storwize_svc.storwize_svc_fc.StorwizeSVCFCDriver
iSCSI:volume_driver=cinder.volume.drivers.ibm.storwize_svc.storwize_svc_iscsi.StorwizeSVCISCSIDriver

Co-Authored By: Slade Baumann <baumann@us.ibm.com>

UpgradeImpact

DocImpact

Partially implements: blueprint refactor-storwize-driver-for-mitaka

Change-Id: I18ddde5c9280a175a4ca296e62ac839389e16c3b
cinder/opts.py
cinder/tests/unit/test_storwize_svc.py
cinder/volume/drivers/ibm/storwize_svc/__init__.py
cinder/volume/drivers/ibm/storwize_svc/storwize_svc_common.py
cinder/volume/drivers/ibm/storwize_svc/storwize_svc_fc.py [new file with mode: 0644]
cinder/volume/drivers/ibm/storwize_svc/storwize_svc_iscsi.py [new file with mode: 0644]
releasenotes/notes/storwize-split-up-__init__-153fa8f097a81e37.yaml [new file with mode: 0644]