]> review.fuel-infra Code Review - openstack-build/neutron-build.git/commit
Remove calls to policy.check from plugin logic
authorSalvatore Orlando <salv.orlando@gmail.com>
Thu, 2 May 2013 17:39:30 +0000 (19:39 +0200)
committerSalvatore Orlando <salv.orlando@gmail.com>
Tue, 14 May 2013 23:49:34 +0000 (01:49 +0200)
commit13f9e02a64eb578547ede95ce7849b264d511619
tree9c3e7da11cd9f92a8163cd26fee504eceac437dc
parent391108a014b3e640525f3c76da248ccd555cddb1
Remove calls to policy.check from plugin logic

Blueprint make-authz-orthogonal

This patch implements part #3 of this blueprint, according to its
specification.
It does so by allowing the view generator in the API layer to strip
off fields which do not satify authorization policies.
Also, some checks in unit tests for plugins relied on the
capability of the plugin to invoke directly the policy engine.
This checks have been removed and replaced by equivalent unit tests.
Finally, this patch required changes to most test cases for API
extensions in order to ensure the resource attribute map was
updated with the extension's attributes

Change-Id: I1ef94a8a628d34697254b68d7a539bd1c636876e
37 files changed:
etc/policy.json
quantum/api/v2/base.py
quantum/common/exceptions.py
quantum/db/l3_db.py
quantum/db/portbindings_db.py
quantum/db/servicetype_db.py
quantum/extensions/agent.py
quantum/extensions/portbindings.py
quantum/extensions/portsecurity.py
quantum/extensions/securitygroup.py
quantum/extensions/servicetype.py
quantum/plugins/bigswitch/plugin.py
quantum/plugins/brocade/QuantumPlugin.py
quantum/plugins/hyperv/hyperv_quantum_plugin.py
quantum/plugins/linuxbridge/lb_quantum_plugin.py
quantum/plugins/mlnx/mlnx_plugin.py
quantum/plugins/nec/nec_plugin.py
quantum/plugins/nicira/QuantumPlugin.py
quantum/plugins/nicira/extensions/nvp_networkgw.py
quantum/plugins/nicira/extensions/nvp_qos.py
quantum/plugins/nicira/nicira_qos_db.py
quantum/plugins/openvswitch/ovs_quantum_plugin.py
quantum/policy.py
quantum/tests/unit/hyperv/test_hyperv_quantum_plugin.py
quantum/tests/unit/mlnx/test_mlnx_plugin.py
quantum/tests/unit/nicira/test_networkgw.py
quantum/tests/unit/nicira/test_nicira_plugin.py
quantum/tests/unit/openvswitch/test_agent_scheduler.py
quantum/tests/unit/test_agent_ext_plugin.py
quantum/tests/unit/test_api_v2.py
quantum/tests/unit/test_extension_extended_attribute.py
quantum/tests/unit/test_extension_portsecurity.py
quantum/tests/unit/test_extension_security_group.py
quantum/tests/unit/test_l3_plugin.py
quantum/tests/unit/test_loadbalancer_plugin.py
quantum/tests/unit/test_policy.py
quantum/tests/unit/test_servicetype.py