]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commit
Fixes 3par driver methods that were double locking
authorKurt Martin <kurt.f.martin@hp.com>
Thu, 1 Nov 2012 00:20:29 +0000 (17:20 -0700)
committerKurt Martin <kurt.f.martin@hp.com>
Thu, 1 Nov 2012 00:20:29 +0000 (17:20 -0700)
commit0ee20a008746a83069c5465b74866f6e41731752
tree9ed39f887b8d40be65e1f92649d708f933292da5
parent11a949c14806c2891e114cd21c08b5b7557862f1
Fixes 3par driver methods that were double locking

There were many cases where the 3par drivers(FC and iSCSI) were double
locking, e.g. we were locking in the individual driver and in ‘common’.
This patch set removes all the locks in ‘common’ except the one on
‘create_cloned_volume’.

The methods ’_get_volume_state’ and ‘_copy_volume’ are only called in
‘create_cloned_volume’, so those locks were removed as well. All the other
methods in ‘common’ are only called by the driver which provide the lock,
except ‘create_volume’ which is also called by ‘create_cloned_volume’.

Change-Id: I660fbd04824bd2837e06480c8298ea5a709fc82a
Fixes: bug 1175791
cinder/volume/drivers/san/hp/hp_3par_common.py