]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commit
Add missing attributes to xml deserializer for volume request
authorStephen Mulcahy <stephen.mulcahy@hp.com>
Fri, 7 Jun 2013 11:52:11 +0000 (11:52 +0000)
committerStephen Mulcahy <stephen.mulcahy@hp.com>
Tue, 11 Jun 2013 07:40:01 +0000 (07:40 +0000)
commit0ec58418103f5097ba3bb0ce0e45fe890be12c2e
tree11f752e71c6c7650fbc74d480e16d4a3d2c88070
parentf34aef3a297955e1f6ebba570ba53acb14f3962e
Add missing attributes to xml deserializer for volume request

The v1 and v2 xml deserializers for volume requests are missing
support for the imageRef, snapshot_id and source_volid attributes
resulting in xml format create volume requests which specify any
of those attributes being silently ignored. This fix adds support
to v1 and v2 and extends the volumes unit tests to check for this.
Also includes some minor debug logging enhancements to make this
easier to find in future.

Fixes bug #1188581

Change-Id: Ib661c4a961c57e682e0e4e6db98d863b3a99cf71
cinder/api/v1/volumes.py
cinder/api/v2/volumes.py
cinder/tests/api/v1/test_volumes.py
cinder/tests/api/v2/test_volumes.py