]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commit
Remove RetypeVD class, fix NFS driver retype
authorEric Harney <eharney@redhat.com>
Tue, 28 Jul 2015 14:19:07 +0000 (10:19 -0400)
committerEric Harney <eharney@redhat.com>
Thu, 13 Aug 2015 14:30:11 +0000 (10:30 -0400)
commit0eb3014195a3e300e6179296c2cfabfa4e785821
tree2104bb830ae5e7131fbf65710d2cec2973195fa9
parent7e84f149e8194e93b109617843e061720ee1930d
Remove RetypeVD class, fix NFS driver retype

retype() only exists in the deprecated VolumeDriver() class
and not BaseVD.  This means that drivers inheriting from *VD
hit attribute errors when trying to call driver.retype().

The thinking here is that RetypeVD isn't really necessary,
since all drivers must implement some version of the retype
method (even if it's a no-op with just a standard return code).

Therefore, just rely on this being in the base driver class(es)
rather than making it a separate abc class.

Closes-Bug: #1478987
Related-Bug: #1471807

Change-Id: Ie0c6f23caf68080a05a10cc7ad245878a057fb02
cinder/tests/unit/test_nfs.py
cinder/volume/driver.py
cinder/volume/drivers/ibm/gpfs.py
cinder/volume/drivers/ibm/storwize_svc/__init__.py
cinder/volume/drivers/ibm/xiv_ds8k.py
cinder/volume/drivers/rbd.py
cinder/volume/drivers/san/hp/hp_lefthand_iscsi.py