]> review.fuel-infra Code Review - openstack-build/heat-build.git/commit
engine : move update_template_diff functions into Resource
authorSteven Hardy <shardy@redhat.com>
Thu, 23 May 2013 10:21:16 +0000 (11:21 +0100)
committerSteven Hardy <shardy@redhat.com>
Thu, 23 May 2013 14:42:14 +0000 (15:42 +0100)
commit0eaeeac888d008ae9f22f9bce6c7451a088f5fe4
treead434e082e62f5562e0940af5b418ee41e4260f1
parent369b7faee736119b6ea8107bce0dac381ed9e613
engine : move update_template_diff functions into Resource

Move the update_template_diff and update_template_diff_properties
functions into resource.Resource - since they now raise
resource.UpdateReplace we can avoid ever calling handle_update if
the resource update will result in replacement

Note a further cleanup will probably be to combine the two diff
functions into one recursive diff, which will further simplify this

Change-Id: I839f0c4448a2d869f35e0a4f19d17f31c5c6f9af
21 files changed:
heat/engine/resource.py
heat/engine/resources/autoscaling.py
heat/engine/resources/cloud_watch.py
heat/engine/resources/instance.py
heat/tests/generic_resource.py
heat/tests/test_autoscaling.py
heat/tests/test_cw_alarm.py
heat/tests/test_eip.py
heat/tests/test_instance_group.py
heat/tests/test_loadbalancer.py
heat/tests/test_nested_stack.py
heat/tests/test_parser.py
heat/tests/test_quantum.py
heat/tests/test_resource.py
heat/tests/test_s3.py
heat/tests/test_security_group.py
heat/tests/test_swift.py
heat/tests/test_user.py
heat/tests/test_volume.py
heat/tests/test_vpc.py
heat/tests/test_waitcondition.py