]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commit
Remove need for CONF acces in brick iscsi
authorJohn Griffith <john.griffith@solidfire.com>
Thu, 26 Sep 2013 21:23:01 +0000 (15:23 -0600)
committerJohn Griffith <john.griffith@solidfire.com>
Thu, 3 Oct 2013 03:23:07 +0000 (21:23 -0600)
commit09f2bea49b853c327762d122d6d9e18f62aed31f
treec2076a7545cec67c4597790157e76db8f724bed3
parentddc585678df8899b42c6d704a848281caa11967d
Remove need for CONF acces in brick iscsi

At some point we'd like brick to be a standalone lib,
and as such we don't want to have a requirement for
CONF files and having duplicate conf entries across
projects.

The better approach would be to let the projects decide
what they want to use, and how they want defaults to be set
and then pass those settings in via __init__ or when calling
the methods that need them.

Partial-Bug: #1230066

Change-Id: Ib108f1abb2948cb896bdad58070daa7a725a205d
cinder/brick/iscsi/iscsi.py
cinder/tests/test_iscsi.py
cinder/volume/driver.py
cinder/volume/drivers/block_device.py
cinder/volume/drivers/lvm.py
etc/cinder/cinder.conf.sample