]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commit
Remove usage of locals() for formatting from cinder.api.*
authorHaomai Wang <haomai@unitedstack.com>
Fri, 14 Jun 2013 07:11:29 +0000 (15:11 +0800)
committerHaomai Wang <haomai@unitedstack.com>
Fri, 14 Jun 2013 11:02:47 +0000 (19:02 +0800)
commit08aab97ced8763597329da56a64ef950f8567f4c
treeb11c814d156ee0cb1f9a5191c86ff2b24e77f349
parent28c6255fc781ca7bfe57c42502a06570a7f0d725
Remove usage of locals() for formatting from cinder.api.*

Using of locals() for formatting string is a nasty thing because:
1) It is not so clear as using explicit dicts
2) It could produce hidden errors during refactoring
3) Changing name of variable causes change in message
4) Creating a lot of unused variables

Fix bug 1171936

Change-Id: Id6a900899db328be067b8139a49c12ce802dd415
cinder/api/contrib/backups.py
cinder/api/contrib/hosts.py
cinder/api/extensions.py
cinder/api/openstack/__init__.py
cinder/api/v1/volumes.py
cinder/api/xmlutil.py