]> review.fuel-infra Code Review - openstack-build/cinder-build.git/commit
Remove those unnecessary statements "return True"
authorJaveme <zhangmei.li@easystack.cn>
Wed, 18 Nov 2015 08:26:08 +0000 (16:26 +0800)
committerJaveme <zhangmei.li@easystack.cn>
Wed, 9 Mar 2016 07:04:39 +0000 (15:04 +0800)
commit066313c0d0b8a90d88b85d12ce302db24bb3b73a
tree4dfe01bca47cfe2bda5f8e60a651ae8780d8703f
parent08b74ce3280f66613e9cae8bce3d00c20d38aff2
Remove those unnecessary statements "return True"

The reasons to remove them:
* These asynchronous API is not necessary to return a value.
* We do not see the purpose of the statements, because it always
  returns true regardless of success or failure.

These statements are unnecessary and misleading, this commit we will
remove these "return True" (Or just remove "True" if it's not at the
end of a function, in order not to change the execution path).

Affected methods:
* delete_volume
* delete_snapshot
* delete_consistencygroup
* update_consistencygroup
* delete_cgsnapshot

Closes-Bug: #1533997
Change-Id: I38bac64b9eb1be6a4756cfcd3894615d2b849551
cinder/tests/unit/test_volume.py
cinder/volume/manager.py